This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Quality of Life improvements for World
action and vocabulary space
#330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
As surfaced in a meeting last week, it can be difficult to extract the vocabulary and action space of light. This PR introduces helpers that ease this flow:
World.get_vocab
: Leveragesget_vocab
functions implemented through theOOGraph
andGraphEvent
s to extract the available possible words that will appear in interacting with a given graph.World.get_action_space
: LeveragesTEMPLATES
introduced for allGraphEvent
types to fill with nodes directly from theOOGraph
. This covers all possible events that may occur in a given graph, not just ones possible from the current state, assuming the graph contents don't change.It also adds templating for
whisper
andtell
events, meaning these now show up inget_possible_actions
calls by default. The free-form text portion of these is noted with<SOMETHING>
and should be filled in.Testing steps